chore: Align sort constraints w/ arrow-rs
#2279
Open
+126
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2279 +/- ##
============================================
+ Coverage 56.12% 57.82% +1.69%
- Complexity 976 1291 +315
============================================
Files 119 146 +27
Lines 11743 13368 +1625
Branches 2251 2372 +121
============================================
+ Hits 6591 7730 +1139
- Misses 4012 4381 +369
- Partials 1140 1257 +117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #. #1854
Rationale for this change
What changes are included in this PR?
BooleanTypefor both functions.TimestampNTZTypetocan_rankfunction.MapTypeon its valuesYearMonthIntervalTypeandDayTimeIntervalTypeb/c Comet Spark doesn't support them.canRank/can_sort_to_indicesfunction w/ Arrow's can_rank and can_sort_to_indicesHow are these changes tested?
CometSortis in the SparkPlan